Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change footer text #1564

Merged
merged 4 commits into from
Oct 24, 2022
Merged

feat: change footer text #1564

merged 4 commits into from
Oct 24, 2022

Conversation

khalatevarun
Copy link
Contributor

Related issues

Fixes #1563

Description

Changed the text on footer.

Motivation & Context

Types of change

  • Refactoring (non-breaking change)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@khalatevarun
Copy link
Contributor Author

@julien-deramond please review

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5702fc6
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6356ad10aad5f0000804266b
😎 Deploy Preview https://deploy-preview-1564--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @khalatevarun.

There's another modification to do here:

### Mandatory Terms & Conditions bar

site/layouts/shortcodes/orange-footer.html Outdated Show resolved Hide resolved
@julien-deramond julien-deramond added docs Improvements or additions to documentation examples enhancement awaiting-reply labels Oct 19, 2022
@julien-deramond julien-deramond mentioned this pull request Oct 24, 2022
6 tasks
@khalatevarun
Copy link
Contributor Author

not able to reuse the same branch
I tried committing the changes here but didn't work

@julien-deramond
Copy link
Member

Reopened it. It works but there's another modification to do mentioned in #1564 (review).

@khalatevarun
Copy link
Contributor Author

noted

@khalatevarun
Copy link
Contributor Author

@julien-deramond can you check once, have converted it to sentence case as well. Hope you are fine with it

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 9e3c9ba into Orange-OpenSource:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-reply docs Improvements or additions to documentation enhancement examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the terms and conditions wording for footers
2 participants