Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): uniformize alt value for Orange logos #1630

Merged
merged 2 commits into from
Nov 16, 2022
Merged

fix(docs): uniformize alt value for Orange logos #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed16a1a
fix: change alt for Orange logo in navbar and scrollspy examples, and…
julien-deramond Nov 15, 2022
69cbec3
Merge branch 'main' into main-jd-fix-alt-for-orange-logo
julien-deramond Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions site/content/docs/5.2/components/navbar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Here's an example of all the sub-components included in a responsive dark-themed
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarSupportedContent" aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle navigation">
Expand Down Expand Up @@ -101,7 +101,7 @@ The `.navbar-brand` can be used to contain most elements, but an anchor works be
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
<h1 class="title">Navbar</h1>
</div>
Expand All @@ -115,7 +115,7 @@ The `.navbar-brand` can be used to contain most elements, but an anchor works be
<div class="container-fluid">
<div class="navbar-brand">
<span class="stretched-link">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</span>
<h1 class="title">Navbar</h1>
</div>
Expand All @@ -138,7 +138,7 @@ Please note that you should also add the `aria-current` attribute on the active
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarNav" aria-controls="navbarNav" aria-expanded="false" aria-label="Toggle navigation">
Expand Down Expand Up @@ -171,7 +171,7 @@ And because we use classes for our navs, you can avoid the list-based approach e
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarNavAltMarkup" aria-controls="navbarNavAltMarkup" aria-expanded="false" aria-label="Toggle navigation">
Expand All @@ -196,7 +196,7 @@ You can also use dropdowns in your navbar. Dropdown menus require a wrapping ele
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarNavDropdown" aria-controls="navbarNavDropdown" aria-expanded="false" aria-label="Toggle navigation">
Expand Down Expand Up @@ -251,7 +251,7 @@ Immediate child elements of `.navbar` use flex layout<!-- Boosted mod: no justif
<div class="container-fluid">
<div class="navbar-brand me-auto">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
<form class="d-flex navbar-item" role="search">
Expand Down Expand Up @@ -307,7 +307,7 @@ Mix and match with other components and utilities as needed.
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbarText" aria-controls="navbarText" aria-expanded="false" aria-label="Toggle navigation">
Expand Down Expand Up @@ -355,7 +355,7 @@ Although it's not required, you can wrap a navbar in a `.container` to center it
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
</div>
Expand All @@ -370,7 +370,7 @@ Use any of the responsive containers to change how wide the content in your navb
<div class="container-md">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>
</div>
Expand All @@ -388,7 +388,7 @@ Fixed navbars use `position: fixed`, meaning they're pulled from the normal flow
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
<h1 class="title">Default</h1>
</div>
Expand All @@ -401,7 +401,7 @@ Fixed navbars use `position: fixed`, meaning they're pulled from the normal flow
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
<h1 class="title">Fixed top</h1>
</div>
Expand All @@ -414,7 +414,7 @@ Fixed navbars use `position: fixed`, meaning they're pulled from the normal flow
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
<h1 class="title">Fixed bottom</h1>
</div>
Expand All @@ -427,7 +427,7 @@ Fixed navbars use `position: fixed`, meaning they're pulled from the normal flow
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
<h1 class="title">Sticky top</h1>
</div>
Expand All @@ -440,7 +440,7 @@ Fixed navbars use `position: fixed`, meaning they're pulled from the normal flow
<div class="container-fluid">
<div class="navbar-brand">
<a class="stretched-link" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
<h1 class="title">Sticky bottom</h1>
</div>
Expand Down
4 changes: 2 additions & 2 deletions site/content/docs/5.2/components/scrollspy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Scroll the area below the navbar and watch the active class change. Open the dro
<div class="bd-example">
<nav id="navbar-example2" class="navbar px-3 mb-3">
<a class="navbar-brand" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" role="img" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" role="img" alt="Boosted - Back to Home" loading="lazy">
</a>
<ul class="nav nav-pills">
<li class="nav-item">
Expand Down Expand Up @@ -72,7 +72,7 @@ Scroll the area below the navbar and watch the active class change. Open the dro
```html
<nav id="navbar-example2" class="navbar px-3 mb-3">
<a class="navbar-brand" href="#">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" role="img" alt="Boosted" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" width="50" height="50" role="img" alt="Boosted - Back to Home" loading="lazy">
</a>
<ul class="nav nav-pills">
<li class="nav-item">
Expand Down
2 changes: 1 addition & 1 deletion site/layouts/partials/docs-navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="container-xxl">
<div class="navbar-brand me-auto me-lg-4">
<a class="stretched-link" href="/">
<img src="/docs/{{ .Site.Params.docs_version }}/assets/brand/orange-logo.svg" width="50" height="50" alt="Back to homepage" loading="lazy">
<img src="/docs/{{ .Site.Params.docs_version }}/assets/brand/orange-logo.svg" width="50" height="50" alt="Boosted - Back to Home" loading="lazy">
</a>
</div>

Expand Down