fix(storybook): generate SB website in _site
intead of site
#1660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Linked to the following issue mentioned in #1626:
Error message when running
npm run storybook-build
and thennpm run storybook
Description
This error is generated by the HTML validator that scans our
site
directory. Since Storybook website is generated insite
, the HTML validator is not very happy with the self-closing tags.But in fact, there's no reason to generate Storybook website in
site
. After the release, we're going to copy_site
and notsite
intogh-pages
.When running locally
npm run storybook
, Storybook website is not generated as HTML files.So the only thing to change here is to keep it working with Netlify which needs to have
site/storybook
directory. I have created a special npm command to differenciate the normal build and the one reserved to Netlify.Non-regression testing
npm run storybook
works locally and doesn't generate_site/storybook
norsite/storybook
npm run storybook-build
and thennpm run storybook
works without the error mentioned in the descriptionnpm run storybook-build
creates_site/storybook
but nothing insite
npm run release
creates_site/storybook
but nothing insite
Types of change
Live previews
Checklist
npm run lint
)