Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): better management of SVGs in examples #1730

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 22, 2022

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Description

Rather than loading the entire sprite file, declare SVGs directly within the corresponding example HTML files.

Types of change

  • Refactoring (non-breaking change)

Live previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices; I have at least run axe

Design

  • (NA) My change respects the design guidelines defined in Orange Design System
  • (NA) My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • (NA) Code review
  • (NA) Design review
  • (NA) A11y review

After the merge

@julien-deramond julien-deramond added docs Improvements or additions to documentation examples enhancement v5 labels Dec 22, 2022
@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit def0105
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63a464b9cfe39700090e32be
😎 Deploy Preview https://deploy-preview-1730--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond marked this pull request as ready for review December 22, 2022 14:10
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions to tackle before approving

@julien-deramond julien-deramond merged commit 0d6d1aa into main Dec 26, 2022
@julien-deramond julien-deramond deleted the main-jd-better-handling-of-svgs-in-examples branch December 26, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement examples v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants