Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forms): change rendering of help texts based on UI Kit v5 #1779

Merged
merged 11 commits into from
Apr 5, 2023
Merged

feat(forms): change rendering of help texts based on UI Kit v5 #1779

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
637b68a
Change rendering of help texts to conform to design
hannahiss Jan 13, 2023
2142f06
add migration guide
hannahiss Jan 13, 2023
d36e6bb
Merge branch 'main' into main-his-help-text
hannahiss Mar 6, 2023
7a60596
Merge branch 'main' into main-his-help-text
hannahiss Mar 7, 2023
2d82720
Merge branch 'main' into main-his-help-text
hannahiss Mar 8, 2023
8493943
Merge branch 'main' into main-his-help-text
hannahiss Mar 31, 2023
ca97e8b
Merge branch 'main' into main-his-help-text
hannahiss Apr 3, 2023
181384f
Merge branch 'main' into main-his-help-text
julien-deramond Apr 4, 2023
402fe23
Update scss/_variables.scss
hannahiss Apr 4, 2023
02a0cd9
Update scss/_variables.scss
hannahiss Apr 4, 2023
2f13c95
Merge branch 'main' into main-his-help-text
julien-deramond Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,10 +1047,11 @@ $btn-social-networks: (

// scss-docs-start form-text-variables
$form-text-margin-top: .375rem !default; // Boosted mod
$form-text-font-size: null !default;
$form-text-font-size: $small-font-size !default;
$form-text-font-style: null !default;
$form-text-font-weight: null !default;
$form-text-color: null !default;
$form-text-font-weight: $font-weight-bold !default; // Boosted mod
hannahiss marked this conversation as resolved.
Show resolved Hide resolved
$form-text-line-height: $line-height-sm !default; // Boosted mod
$form-text-color: $text-muted !default;
hannahiss marked this conversation as resolved.
Show resolved Hide resolved
// scss-docs-end form-text-variables

// scss-docs-start form-label-variables
Expand Down
1 change: 1 addition & 0 deletions scss/forms/_form-text.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
@include font-size($form-text-font-size);
font-style: $form-text-font-style;
font-weight: $form-text-font-weight;
line-height: $form-text-line-height; // Boosted mod
color: $form-text-color;
}
1 change: 1 addition & 0 deletions site/content/docs/5.3/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ Learn more by reading the new [color modes documentation]({{< docsref "/customiz
<li><code>$form-invalid-color</code></li>
<li><code>$form-invalid-color-dark</code></li>
<li><code>$form-range-thumb-hover-bg</code></li>
<li><code>$form-text-line-height</code></li>
<li><code>$form-valid-border-color</code></li>
<li><code>$form-valid-border-color-dark</code></li>
<li><code>$form-valid-color</code></li>
Expand Down