Chore merge from 8fddb9f to a3f8480 #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 3.6%, saving 11.68 KB.
55 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
julien-deramond
changed the title
louismaximepiton
requested changes
Mar 8, 2023
scss/mixins/_buttons.scss
Outdated
| @@ -27,7 +27,7 @@ | |||
| --#{$prefix}btn-hover-color: #{$hover-color}; | |||
| --#{$prefix}btn-hover-bg: #{$hover-background}; | |||
| --#{$prefix}btn-hover-border-color: #{$hover-border}; | |||
| --#{$prefix}btn-focus-shadow-rgb: #{$btn-focus-shadow-color}; // Boosted mod | |||
| --#{$prefix}btn-focus-shadow-rgb: #{$btn-focus-shadow-color}; // Boosted mod: instead of `#{to-rgb(mix(color-contrast($link-color), $link-color, 15%))}` | |||
There was a problem hiding this comment.
Unless I'm mistaken, but the changes of twbs/bootstrap@d576590 weren't in this file 🤔
There was a problem hiding this comment.
Oh wow, I'm gonna check. Thx LM
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twbs/bootstrap@2dc329d: nothing to do here since the variants displayed in Bootstrap (in the buttons, breadcrumbs, badges, and jumbotrons examples) don't exist in our design guidelines. Designers have been contacted to check if some things could be integrated into our design guidelines or if already existing stuff is matching these examples. Let's tackle it in other PRs if needed.twbs/bootstrap@2b31a6b: nothing to do here, this fix is already in Boostedtwbs/bootstrap@5241b98: nothing to do since we don't have any dashboard examples in Boostedtwbs/bootstrap@2e2ca49+twbs/bootstrap@c634528: nothing to do here since already backported in Boostedtwbs/bootstrap@8a72501: already done via Dependabottwbs/bootstrap@912cfe5: nothing to do since this example doesn't exist as is in Boostedtwbs/bootstrap@cff5c60: nothing to do here since.mt-1would be worse in Boosted doctwbs/bootstrap@833da72: nothing to do since already fixed in Boostedtwbs/bootstrap@3cec38c: nothing to do since we don't have this headers example in Boosted