Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary stuff in boosted-*.scss files #2196

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Aug 17, 2023

Related issues

Closes #2153

Description

Remove unnecessary stuff in boosted-grid.scss

Motivation & Context

Lighter code and smaller bundle size.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices; I have at least run axe

Design

  • (NA) My change respects the design guidelines defined in Orange Design System
  • (NA) My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • (NA) My new component is well displayed in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@MewenLeHo MewenLeHo self-assigned this Aug 17, 2023
@MewenLeHo MewenLeHo marked this pull request as draft August 17, 2023 11:59
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 68b600d
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64e45dcc013aff0008078f44
😎 Deploy Preview https://deploy-preview-2196--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MewenLeHo

This comment was marked as outdated.

scss/boosted-grid.scss Outdated Show resolved Hide resolved
@MewenLeHo MewenLeHo changed the title Remove unnecessary stuff in boosted-grid.scss Remove unnecessary stuff in boosted-*.scss files Aug 18, 2023
@MewenLeHo
Copy link
Contributor Author

MewenLeHo commented Aug 18, 2023

No difference spotted for boosted-reboot.scss vs. bootstrap-reboot.scss.
boosted-reboot.css is bigger but we have more variables so it seems pretty normal.

@MewenLeHo MewenLeHo marked this pull request as ready for review August 18, 2023 09:30
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to have this!

scss/boosted-grid.scss Show resolved Hide resolved
@MewenLeHo
Copy link
Contributor Author

Note: we decided to go closer to Bootstrap by incorporating the following commit twbs/bootstrap@5ac9fe8

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@julien-deramond julien-deramond merged commit 1aa4193 into main Aug 22, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-mlh-fix-boosted-grid-scss branch August 22, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

boosted-grid.css contains too much stuff
3 participants