docs(analytics): try absolute URL #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
force-pushed
the
chore/docs-tarteaucitron
branch
3 times, most recently
from
d5c41c5
to
bb6dd2f
Compare
ffoodd
force-pushed
the
chore/docs-tarteaucitron
branch
8 times, most recently
from
ea8a866
to
ec71ea3
Compare
- installed through NPM - implement custom CSS right in our docs styles - drop useless services and massive CSS cleanup - move init() to docs scripts to avoid inline unminified script tag - use TAC events to customize DOM, instead of altering lib sources - improve TAC init to place it at the DOM start and link to our Cookies page
ffoodd
force-pushed
the
chore/docs-tarteaucitron
branch
5 times, most recently
from
d0ee96c
to
fd05022
Compare
ffoodd
force-pushed
the
chore/docs-tarteaucitron
branch
from
fd05022
to
e886e1f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to make things work as intended by:
tarteaucitron.jsfile)tarteaucitronboosted.cssfile.init({})doesn't work as intended for now…To do:
include CSS in our docs CSS files, maybe?← nope | yes → and refactor it to comply our current best practices and stylelint rules, obviously…try to improve markup to be accessible…servicesand(through Hugo mounts), to minify them on production server and handle them in dynamic assets instead of static ones.langfiles