Buttons #621
Merged
Buttons #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ffoodd
force-pushed
the
feature/branded-buttons
branch
2 times, most recently
from
d931b80
to
54b1654
Compare
ffoodd
force-pushed
the
feature/branded-buttons
branch
3 times, most recently
from
9fb4ece
to
af66fa3
Compare
Using SVG spriteand, well, nothing else. But added docs.
ffoodd
force-pushed
the
feature/branded-buttons
branch
from
af66fa3
to
80eade4
Compare
ffoodd
force-pushed
the
feature/branded-buttons
branch
6 times, most recently
from
ffd9239
to
de08ed9
Compare
ffoodd
force-pushed
the
feature/branded-buttons
branch
6 times, most recently
from
42018ba
to
fa54ada
Compare
ffoodd
force-pushed
the
feature/branded-buttons
branch
from
fa54ada
to
063e61f
Compare
Used in pagination, close button, and back-to-top to embed an icon as a mask-image.
Adding - `focusable="false"` for IE / Edge, - `aria-hidden="true"` for decorative `<svg>`, but also `<img src=".svg" alt="">` for Safari
ffoodd
force-pushed
the
feature/branded-buttons
branch
from
063e61f
to
0a2f616
Compare
Closed
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #521
.btn-icon).btn-closetoo) →.btn-no-outline, to stick to Bootstrap naming convention..btn-closemight inherit from icon buttonsmaskinstead offilter?button-icon()mixin.rebase -ifeat(…): …messageback-from-v4)Side topic:
mask-imageas another way of colorizing inline SVG:$chevron-icon-disabled$form-select-disabled-indicatorselectsince its a replaced element.aria-hidden="true"andfocusable="false"to decorative SVGsPreview: https://deploy-preview-621--boosted.netlify.app/docs/5.0/components/buttons