-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transitions don't use "inDuration" #357
Labels
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#224 Report
All transitions use hardcoded "inDuration" of 0.6s, although they have a constructor-parameter for it. It would further be great to have them flexible, because 0.6s is really slow for some situations and animations.
Environment
Dependency management
What did you expect to happen?
I expect to use animations to use the given constructor-parameters for animation durations or potentially be configurable
What happened instead?
They use 0.6s hardcoded in any case
PopupDialog/PopupDialog/Classes/TransitionAnimations.swift
Line 89 in 014f7b2
PopupDialog/PopupDialog/Classes/TransitionAnimations.swift
Line 120 in 014f7b2
PopupDialog/PopupDialog/Classes/TransitionAnimations.swift
Line 151 in 014f7b2
The text was updated successfully, but these errors were encountered: