Add redcap_event_read() as wrapper for Export Events API method
#460
Conversation
There was a problem hiding this comment.
@ezraporter, this looks fantastic. Thanks for paying attention to all the little details and conventions of the package. I pointed out a few cosmetic requests.
Unrelated to your code, I'm surprised why the API returns arm_num, but the table's field is arm_id. I guess the PHP code is renaming it.
The only conceptual issue I'm considering is the data type of event_id. Admittedly this is fairly minor too. In the redcap_events_metadata table, the event_id field is an int(10). I think it would be easier if R uses and integer instead of a floating point. I think this needs only three changes.
- Once in the real function's
col_typesdefinition, and - twice the test code's col_types.
Also,
- please give yourself credit in the description file as a contributor
|
@wibeasley, thanks for looking at this! I think I addressed (and accepted) all your suggestions. Looks like I'm already in the |
|
@wibeasley happy new year! No rush on this but wanted to check where you were |
|
@ezraporter, the changes and everything look great. Thanks for doing it and sorry I missed the Dec 16 changes. |
|
No worries! Thanks! |
Closes #457
I adhered pretty closely to the template of
redcap_arm_export()here. For a few of the tests I added data to existing directories ininst/test-data/. I went with the naming conventionevent.csvfor the rawcsvresponse from the Export Events methods but feel free to rename!