Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some modules #162

Closed
fmigneault opened this issue Mar 28, 2019 · 0 comments · Fixed by #176
Closed

Rename some modules #162

fmigneault opened this issue Mar 28, 2019 · 0 comments · Fixed by #176
Assignees
@fmigneault
Labels
enhancement Improvements in term of performance or behaviour
Milestone
1.x.x

Comments

@fmigneault
Copy link
Collaborator

fmigneault commented Mar 28, 2019 •
edited
Loading

  • rename all api_<> files to <> to avoid repetitive api
  • rename api_rest_schemas to simply schemas
  • rename all <>_defintions to <> to avoid repetitive defintions cannot be done because it causes self import

Must be done in a new minor version since could be imported from elsewhere, which can lead to breaking code.
@fmigneault fmigneault added the enhancement Improvements in term of performance or behaviour label Mar 28, 2019
@fmigneault fmigneault self-assigned this Mar 28, 2019
@fmigneault fmigneault added this to the 0.10.0 milestone Mar 28, 2019
@fmigneault fmigneault mentioned this issue Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmigneault fmigneault

Labels
enhancement Improvements in term of performance or behaviour
Projects
None yet
Milestone
1.x.x
Development

Successfully merging a pull request may close this issue.

formatting and improvements Ouranosinc/Magpie
1 participant
@fmigneault