Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept header checks #259

Merged
merged 1 commit into from
Mar 10, 2020
Merged

accept header checks #259

merged 1 commit into from
Mar 10, 2020

Conversation

fmigneault
Copy link
Collaborator

allow more accept header content-type if ui/static route is requested for app mounted behind proxy with additional prefix than just /magpie

@fmigneault fmigneault added the enhancement Improvements in term of performance or behaviour label Mar 9, 2020
@fmigneault fmigneault requested a review from ldperron March 9, 2020 20:18
@github-actions github-actions bot added the api Something related to the API operations label Mar 9, 2020
@fmigneault
Copy link
Collaborator Author

@ldperron just as additional measure of the problem encountered, maybe it can help avoid it without further hacking around of the server config

@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #259 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   71.12%   71.13%           
=======================================
  Files          90       90           
  Lines        7121     7123    +2     
=======================================
+ Hits         5065     5067    +2     
  Misses       2056     2056           
Impacted Files Coverage Δ
magpie/api/generic.py 83.58% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2877c...0a0298b. Read the comment docs.

… for app mounted behind proxy with additional prefix than just /magpie
@fmigneault fmigneault merged commit 1d9e203 into master Mar 10, 2020
@fmigneault fmigneault deleted the more-prefix-path branch March 10, 2020 19:21
fmigneault added a commit that referenced this pull request Mar 11, 2020
more update of accept header parsing (related to #259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the API operations enhancement Improvements in term of performance or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants