Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service type to permission webhooks #582

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

ChaamC
Copy link
Contributor

@ChaamC ChaamC commented May 30, 2023

Add the service.type data in the Webhooks for a Permission change, even if the resource is not a service,
since the root service type is necessary to Cowbird.

@github-actions github-actions bot added api Something related to the API operations doc Documentation improvements or building problem tests Test execution or additional use cases webhook Item related to webhooks functionality. labels May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (63b0fb3) 80.76% compared to head (45f6085) 80.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   80.76%   80.77%           
=======================================
  Files          73       73           
  Lines       10160    10162    +2     
  Branches     1816     1816           
=======================================
+ Hits         8206     8208    +2     
  Misses       1630     1630           
  Partials      324      324           
Impacted Files Coverage Δ
magpie/api/management/group/group_utils.py 90.06% <100.00%> (ø)
magpie/api/management/user/user_utils.py 97.21% <100.00%> (ø)
magpie/api/webhooks.py 85.91% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor formatting to adjust.

magpie/api/webhooks.py Outdated Show resolved Hide resolved
@fmigneault fmigneault merged commit 44794e0 into master Jun 1, 2023
@fmigneault fmigneault deleted the add-service-type-to-webhook branch June 1, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the API operations doc Documentation improvements or building problem tests Test execution or additional use cases webhook Item related to webhooks functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants