Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4896: Remove OnCellValueChange trigger from ApplyRowValidations API #426

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented Jul 26, 2024

This PR is to remove the OnCellValueChange trigger from ApplyRowValidations API

What was happening

  • When using the ApplyRowValidations Client Action in a Grid with Dropdown Dependency, the child dropdown cell was being erased
  • This happened because the ApplyRowValidations triggers the OnCellValueChange event of the Column and the Dropdown Column's _parentCellValueChangeHandler method was not considering this scenario.

What was done

  • Removed the OnCellValueChange event trigger when calling the ApplyRowValidations.
  • This intruduces a breaking change.

Test Steps

  1. Go to a page with a Grid with Dropdown Dependency
  2. Run the ApplyRowValidations Client Action
  3. Check that no cells were erased
  4. Check that the OnCellValueChange was not triggered

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner July 26, 2024 13:36
Copy link

sonarcloud bot commented Jul 26, 2024

Copy link
Contributor

@rugoncalves rugoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking of behavior, and needs to be well noted and documented in the release notes.

@OS-giulianasilva OS-giulianasilva merged commit fe696c6 into dev Jul 31, 2024
8 of 13 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4896-2 branch July 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants