Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pie Chart Type & Stack Percent Bar Charts #108

Merged
merged 8 commits into from
Jun 26, 2015
Merged

Add Pie Chart Type & Stack Percent Bar Charts #108

merged 8 commits into from
Jun 26, 2015

Conversation

jrking4
Copy link
Contributor

@jrking4 jrking4 commented Jun 23, 2015

Add Non 3D Pie Chart Type
Add Grouping Option to Bar Charts - To allow for Stack and Percent Stacked Charts

@jrking4 jrking4 mentioned this pull request Jun 23, 2015
@jrking4 jrking4 changed the title Add Pie Chart Type Add Pie Chart Type & Stack Percent Bar Charts Jun 23, 2015
@Progi1984
Copy link
Member

@jrking4 Good job for your pull request (very)... Could you look into implementing these improvements in the ODPresentation writer ? and improve Sample_05 ?

Add Option to Specify Data Label Number Format (so stacked % displays percent)
@jrking4
Copy link
Contributor Author

jrking4 commented Jun 25, 2015

@Progi1984 No problem & glad to contribute. Sample_05 is updated. ODPresentation Writer should work with new chart types.

@Progi1984 Progi1984 added this to the 0.4.0 milestone Jun 26, 2015
@Progi1984 Progi1984 self-assigned this Jun 26, 2015
@Progi1984
Copy link
Member

@jrking4 Perfect.... For finishing, could you add a line to changelog.md ?

Progi1984 added a commit that referenced this pull request Jun 26, 2015
Add Pie Chart Type & Stack Percent Bar Charts
@Progi1984 Progi1984 merged commit d950c89 into PHPOffice:develop Jun 26, 2015
@Progi1984
Copy link
Member

@jrking4 I will add it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants