Update AbstractSlide.php #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Shape position issue that pops up when trying to animate
Added ability to find a PNG file
|
@Aggiekev Hi Could you merge develop branch of PhpPresentation in your branch, please ? Thank you |
Done. |
|
@Aggiekev Thank you for your contribution. I don't think the error is there because ShapeId is an unsigned Int and begins to 0. I think the error is You should revert your modifications and replace 1 by 0 and test it. |
…evelop # Conflicts: # src/PhpPresentation/Shape/Drawing/Base64.php # src/PhpPresentation/Style/Border.php # src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the shapeId off at 0 prevented the first element on the slide from being animated and made all other animations off by one. Changing the default input to 1 fixes this.