Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPoint2007 Reader : Load images in their initial format (and not by default in PNG) #553

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

polidog
Copy link
Contributor

@polidog polidog commented Jul 26, 2019

Load PowerPoint 2007 images converted all files to png.
It's only default used.
I'm changed mimeType and renderingFunction.

@Progi1984
Copy link
Member

Hi @polidog, thank you for your contribution. Could you rebase your branch on develop ? Thanks.

@polidog polidog changed the base branch from master to develop October 14, 2019 14:58
@polidog
Copy link
Contributor Author

polidog commented Oct 14, 2019

@Progi1984 Why is rebase on develop? I'm changed base branch to develop. Is this all right?

@Progi1984
Copy link
Member

@polidog Thanks for develop. Could you merge this PR polidog#1 using "squash & merge " ?
image

@polidog
Copy link
Contributor Author

polidog commented Oct 14, 2019

@Progi1984 Thanks your PR. I'm marged done.

@Progi1984 Progi1984 changed the title Fix load PowerPoint 2007 images. PowerPoint2007 Reader : Load images in their initial format (and not by default in PNG) Oct 14, 2019
@Progi1984 Progi1984 merged commit 6dc7fc2 into PHPOffice:develop Oct 14, 2019
@Progi1984
Copy link
Member

Thanks @polidog for your contribution.

@Progi1984 Progi1984 added this to the 0.10.0 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants