[Plugin] Midi File Import 수정 #3 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ask users to search the tracker first * Ask for the LMMS version in bug reports
We already run them on CircleCI with a newer Qt version.
…porting tracks. Calling via QMetaObject::invokeMethod should be thread safe. Crash callstack: QWidget::move SongEditor::updatePosition Song::stop Song::stopExport ProjectRenderer::run QThreadPrivate::start
Add `override` and remove `virtual` where applicable
`PianoRoll::mouseDoubleClickEvent` wasn't forwarding the event to the base class when not acting on the event. The base class calls `mousePressEvent`. Fixes LMMS#3005
`PianoRoll::mouseDoubleClickEvent` wasn't forwarding the event to the base class when not acting on the event. The base class calls `mousePressEvent`. Fixes LMMS#3005
Add issue templates
* d/control: http -> https * d/control: rearrange lists (one item per line + alphabetically ordered) * d/copyright: http -> https * Delete contributors.patch (integrated now) * d/series: removes contributors.patch
Original code by @gi0e5b06.
형변환으로 인한 컴파일 에러 수정 (형변환이 엄격한 컴파일러에서 에러가 발생)
미디 파일 정보를 읽은 후 모든 Model 정보의 signal 함수(dataChanged)을 호출 하도록 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
https://www.notion.so/pozalabs/LMMS-9ac2570f2c2b4d79b752dd8aa1a9ec20#cdd8e4665adf4e258f617246e39fac54
변경 사항
midi File Import 시 object model에서 signal을 호출하도록 수정
TODO (Optional)
-현재 dataChanged() signal 함수를 동일하게 호출(emit) 하고 있음 dataChanged는 데이터가 바뀔때 호출되야 하므로 init시 호출 될 함수 추가가 필요
ex) dataInit() signal 함수를 추가하여 dataCahgned() 함수와 구분할수 있도록 디자인을 분리하여 설계(slot 함수는 같음)
Followers (Optional)
@novdov @PhysSong