Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Effect #1834

Open
thewilkybarkid opened this issue Aug 1, 2024 · 0 comments
Open

Use Effect #1834

thewilkybarkid opened this issue Aug 1, 2024 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue Aug 1, 2024
@thewilkybarkid
Make it easier to evolve
84d05c8 
Refs #1834
thewilkybarkid added a commit that referenced this issue Aug 5, 2024
@thewilkybarkid
Make it easier to evolve by treating the locale like a regular depend…
0d1ebb4 
…ency

Refs #1817, #1834, f256f32
thewilkybarkid added a commit that referenced this issue Aug 5, 2024
@thewilkybarkid
Remove unused syntax
6dbe3a4 
Refs #1817, #1834; reverts f256f32
thewilkybarkid added a commit that referenced this issue Aug 5, 2024
@thewilkybarkid
Fix import
7d7e70d 
Refs #1817, #1834, 0d1ebb4
thewilkybarkid added a commit that referenced this issue Aug 5, 2024
@thewilkybarkid
Remove duplication
cebb8d8 
Refs #1834
thewilkybarkid added a commit that referenced this issue Aug 5, 2024
@thewilkybarkid
Simplify configuration
b6e72da 
Refs #1834, https://docs.github.com/en/actions/using-containerized-services/creating-redis-service-containers#running-jobs-directly-on-the-runner-machine
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Create a place to start a migration to Effect
b7ffda6 
Refs #1834
erkannt added a commit that referenced this issue Aug 28, 2024
@erkannt
Prepare for removal of terminus by moving one of its responsibilities
d3b57c9 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Remove Terminus to allow Effect to control the lifecycle of the server
8f6b150 
Refs #1834
erkannt added a commit that referenced this issue Aug 28, 2024
@erkannt
Move logging responsibility as a step to making the express app a Layer
e69698b 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Make it easier to evolve by removing a superfluous layer
7b88e6b 
Refs #1834
erkannt added a commit that referenced this issue Aug 28, 2024
@erkannt
Prepare express to be used via Effect dependency management
01eef17 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Make it easier to read
3ef035e 
Refs #1834
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Make it easier to understand by removing an Effect layer
504440e 
Refs #1834
erkannt added a commit that referenced this issue Aug 28, 2024
@erkannt
Get ready to have Effect manage the Redis lifecycle
d999759 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Remove deprecated functions
e6c1fb1 
CI started failing as there was an unexpected update to fast-check, and local ESLint caches prevented us from seeing the problems in unchanged code.

Refs #1834, 8f6b150
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Fix paths beginning with a double slash
3fc0404 
CI started failing as there was an unexpected update to fast-check. This version now generates URLs containing '//' as the beginning of the path, which then break's constructing URL objects which consider it to be an invalid protocol relative URL.

Refs #1834, 8f6b150, dubzzz/fast-check#4896
thewilkybarkid added a commit that referenced this issue Aug 28, 2024
@thewilkybarkid
Remove the healthcheck from request/response logging
37cea29 
Refs #1834, d3b57c9
thewilkybarkid added a commit that referenced this issue Aug 29, 2024
@thewilkybarkid
Avoid surprise fast-check updates
13e5930 
Refs #1834, 8f6b150
thewilkybarkid added a commit that referenced this issue Aug 29, 2024
@thewilkybarkid
Group fast-check updates
7fc18f6 
Refs #1834, 13e5930
thewilkybarkid added a commit that referenced this issue Sep 2, 2024
@thewilkybarkid
Remove a dependency
f6031ec 
The it-all module seems to be incompatible with Jest's ESM support. I have no idea why, but it's easy enough to replace with Effect.

Refs #1834, #1900
thewilkybarkid added a commit that referenced this issue Sep 4, 2024
@thewilkybarkid
Expose multiple roles by giving it a name
a1f6c1a 
Refs #1834
erkannt added a commit that referenced this issue Sep 4, 2024
@erkannt
Expose the express depencendencies by extracting it to a seperate module
42f6830 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Sep 4, 2024
@thewilkybarkid
Start encapsulating Redis into a service
26b47df 
There's a name collision between the Effect service tag and the IoRedis export; we've decided to alias the latter for the moment, but the collision might become encapsulated.

Refs #1834
erkannt added a commit that referenced this issue Sep 4, 2024
@erkannt
Separate lifecycle of Redis from lifecycle of Express
84f187d 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Sep 4, 2024
@thewilkybarkid
Encapsulate the Redis lifecycle in the service
aa8bebf 
Refs #1834
erkannt added a commit that referenced this issue Sep 4, 2024
@erkannt
Get ready to remove duplicate loading of env vars
004557e 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Sep 4, 2024
@thewilkybarkid
Remove duplication
c734567 
Refs #1834
erkannt added a commit that referenced this issue Sep 4, 2024
@erkannt
Extract and name to improve legibility
0db3be5 
Refs: #1834
thewilkybarkid added a commit that referenced this issue Sep 4, 2024
@thewilkybarkid
Surface the context required by the application
d0adcdd 
We've decided to put all the context tags in one module, which different parts of the application can depend on. This keeps the tags separate from the implementations.

Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 11, 2024
@thewilkybarkid
Add the request ID to the Effect logger
3d92e85 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 11, 2024
@thewilkybarkid
Ensure Effect responses have the X-Robots-Tag header
1b7cd85 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 11, 2024
@thewilkybarkid
Ensure Effect responses have the same Helmet headers
fa0756c 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 11, 2024
@thewilkybarkid
Move the robots.txt file to Effect
5fbf437 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 12, 2024
@thewilkybarkid
Log the server lifecycle
1cdb8e1 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 12, 2024
@thewilkybarkid
Avoid a race condition
82c677e 
I've not seen it happen, but it's safer to set the event listener before starting processing.

Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Make the current locale available to Effect routes
6633cba 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Make the page template available to Effect routes
88ae47e 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Create a stub route for an Effect page
ed7a0b8 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Make pseudonyms compatible with Effect
4971a3d 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Make non-empty strings compatible with Effect
7e6fb76 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Make the logged-in user available to Effect routes
b806753 
 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 19, 2024
@thewilkybarkid
Extract code for reuse
47f1613 
 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Configure fetch in the same way
f774a10 
 
Refs #1941, #1834, 0570ad7
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Get ready to use existing data loaders in Effect
e967853 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Make getPreprint compatible with Effect
fc91b02 
 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Only decode environment variables when we want to
cd7eb2d 
 
Refs #1941, #1834, 7995083
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Make getPrereview compatible with Effect
8e95b05 
 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Support all page types
94d720c 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Make an arbitrary compatible with Effect
8f17ebc 
Refs #1941, #1834
thewilkybarkid added a commit that referenced this issue Sep 20, 2024
@thewilkybarkid
Have Effect write to the same logger
c2e33ca 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 25, 2024
@thewilkybarkid
Ensure errors from the hyper-ts app are caught correctly
ce2675a 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 25, 2024
@thewilkybarkid
Silently ignore cases where Effect has responded to the request already
e33d15d 
If the client drops the connection, Effect recognises this and finishes the response with '204 No Content'. Routes that are still served by hyper-ts, however, then try to send a response that Node rejects. This change recognises these and skips over them to avoid noisy log messages.

Refs #1834, https://expressjs.com/en/guide/error-handling.html, https://discord.com/channels/795981131316985866/1283492544256278601/1283741118168829973
thewilkybarkid added a commit that referenced this issue Sep 25, 2024
@thewilkybarkid
Include spans in the logger
8b3e5e0 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 25, 2024
@thewilkybarkid
Log requests and responses handled by Effect
e58d024 
Refs #1834
thewilkybarkid added a commit that referenced this issue Sep 26, 2024
@thewilkybarkid
Make room for running things alongside the HTTP server
f1f6775 
Refs #1834, #1941
thewilkybarkid added a commit that referenced this issue Sep 26, 2024
@thewilkybarkid
Create a place to react to events
255d419 
Refs #1834, https://effect.website/docs/guides/concurrency/pubsub
thewilkybarkid added a commit that referenced this issue Sep 26, 2024
@thewilkybarkid
Remove debugging listener
1c2148e 
Refs #1834, 255d419
thewilkybarkid added a commit that referenced this issue Oct 2, 2024
@thewilkybarkid
Let us know when there's a defect
28bebe2 
As the Effect server catches defects and returns a 500 response, we need to see when this happens.

Refs #1834, #1973
thewilkybarkid added a commit that referenced this issue Oct 7, 2024
@thewilkybarkid
Remove a memory leak
d146ee4 
`express.use()` is stateful, so a middleware was added on each request handled. This change creates a fresh Express app on each request instead, which feels wasteful but should remove the leak.

Refs #1834, e33d15d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid