Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta #1

Merged
merged 16 commits into from
Feb 8, 2024
Merged

Add meta #1

merged 16 commits into from
Feb 8, 2024

Conversation

luraess
Copy link
Member

@luraess luraess commented Feb 6, 2024

This PR adds backbone infra for testing and documentation. It mostly re-uses the assets from FastIce.jl and needs further tweaks before merging:

Upon making Chmy.jl public one should

  • register Chmy in codecov
  • register Chmy in Buildkite
  • add basic testing and decide whether GPU testing and extensions should be added
  • further extend and improve the doc
  • and certainly more ...

on:
push:
branches:
- lr/doc-ci # update to match your development branch (master, main, dev, trunk, ...)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be adapted upon merging into main


deploydocs(
repo = "github.com/PTsolvers/Chmy.jl.git",
devbranch = "lr/doc-ci",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be adapted upon merging into main

@luraess
Copy link
Member Author

luraess commented Feb 7, 2024

@utkinis I've added device handling to extensions as well - you may want to x-check that. Else, all CI and doc functionality seems to be working and this PR should be ready to merge from my side.

@luraess luraess requested a review from utkinis February 7, 2024 22:50
Copy link
Member

@utkinis utkinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @luraess! Looks good to me, will merge now

@utkinis utkinis merged commit edd294a into main Feb 8, 2024
10 checks passed
@utkinis utkinis deleted the lr/doc-ci branch February 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants