-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【mc_att_control】 Remove unnecessary defaults. #9077
Comments
@xdwgood Don't use the
|
😃 I don't think we need this extra variable. https:/PX4/Firmware/blob/master/src/modules/mc_att_control/mc_att_control_main.cpp#L95
This variable
ATTITUDE_TC_DEFAULT
is used to adjust the pid.Use it here: https:/PX4/Firmware/blob/master/src/modules/mc_att_control/mc_att_control_main.cpp#L534
I think we can use this parameter
MC_ROLL_TC
to directly adjust the pid. https:/PX4/Firmware/blob/master/src/modules/mc_att_control/mc_att_control_params.c#L54It is also a mistake to follow the current logic. https:/PX4/Firmware/blob/master/src/modules/mc_att_control/mc_att_control_params.c#L45
Should : Increase if the system is too twitchy, Reduce if the response is too slow and sluggish.
@MaEtUgR @Stifael Do I understand that correctly? :rabbit2:
The text was updated successfully, but these errors were encountered: