Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: mission WP reached - satisfy based on mavros topics instead of di… #8879

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

lamping7
Copy link
Member

@lamping7 lamping7 commented Feb 13, 2018

…stance check

Motivation: Checking distance is nice feedback, but it is not good criteria for a test because of the varying acceptance radii of FW WPs. Which is based on the switch or turn distance: where _L1_distance = _L1_ratio * ground_speed and _L1_ratio = 1.0f / M_PI_F * _L1_damping * _L1_period.

Also added: It now logs the distance to the WP initially and every 10 seconds (which may be nice to see for future, possibly longer, missions).

Locally tested: console log - https://pastebin.com/nfTJapu0

@lamping7
Copy link
Member Author

lamping7 commented Feb 13, 2018

@dagar One of the intermittent bugs showed it self during this CI run. With this PR, you can now see that the reached flag got set, but the mission (seq_current) isn't advancing to the next item, causing it to loiter endlessly. Hopefully this is a clue for you.

Take a look at the logs:

@dagar dagar self-requested a review February 13, 2018 16:19
@dagar
Copy link
Member

dagar commented Feb 14, 2018

Thanks!

@dagar dagar merged commit c22dc2b into PX4:master Feb 14, 2018
@lamping7 lamping7 deleted the pr-remove_ci_dist_check branch February 28, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants