commander delete GPS receiver checks and minor cleanup #8914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
previously approved these changes
Feb 19, 2018
|
Ci failed. |
dagar
force-pushed
the
pr-commander_cleanup
branch
from
c1b6b76
to
eb59d7d
Compare
dagar
changed the title
|
CI passing. |
LorenzMeier
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b6ee38e -
Due to the gpssim driver and a rare race condition the SITL tests are occasionally getting stuck in gps failure. The commander GPS receiver checks are superseded by the estimator checks and probation periods for local and global position validity. This seems like a good excuse to delete the old code.
The other commits are minor commander cleanup I came across in the process.