Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr aero battery initialization hotfix #8940

Merged
merged 2 commits into from
Feb 24, 2018

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Feb 22, 2018

On the Intel Aero and probably also other specific platforms the first measured voltage values despite connected battery are unuasable. The solution here is to start filtering and determining warning only after a measurement above 2.1V was received. This condition was anyways used before to determine if the battery status report gets filled at all.

I bench tested this on an Intel Aero. Can someone else please also confirm?

fixes #8930

On the Intel Aero and probably also other specific platforms
the first measured voltage values despite connected battery are unuasable.
The solution here is to start filtering and determining warning
only after a measurement above 2.1V was received.
@MaEtUgR MaEtUgR added the bug label Feb 22, 2018
@MaEtUgR MaEtUgR self-assigned this Feb 22, 2018
@ChristophTobler
Copy link
Contributor

@santiago3dr Can you please also test this on the platforms that you had issues with battery estimation?

@LorenzMeier LorenzMeier requested a review from a team February 22, 2018 15:10
@LorenzMeier
Copy link
Member

@MaEtUgR Please assign @PX4/testflights as reviewer for things that need on-HW testing. @PX4/testflights please make sure this doesn't break any other config that you fly. Please test different vehicles.

@Avysuarez
Copy link

Flight with pixhawk 1- V2. No issues.
https://review.px4.io/plot_app?log=ef52ad42-e479-4f9c-a79d-3e1fcffeaff5

Flight with pixhawk Pro - V4pro. No issues.
https://review.px4.io/plot_app?log=5ab4353a-7cb6-419d-9883-312da3694415

@r0gelion
Copy link
Contributor

I noticed a recurrent warning message in the log from Pixhawk 1 - V2
image

What does this mean?

Regards

@santiago3dr
Copy link

pixracer (v4):
https://logs.px4.io/plot_app?log=6858c85e-16cb-4960-b258-c24f393c87ed

snapdragon (eagle):
https://logs.px4.io/plot_app?log=f0680eb8-ed03-4094-a7b5-db58e4fd9b14

all features working as expected; no notable difference from master

aerotenna (OcPoc):
https://logs.px4.io/plot_app?log=90f9c02b-9304-4a54-bf50-a1a83d80c850

looks to have resolved issue #8932

@dannyfpv
Copy link

Copy link
Contributor

@r0gelion r0gelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR performed well on other platforms than the aero, we couldn't test it in the aero due to connection issues, but @MaEtUgR tested it (bench testing).

@LorenzMeier LorenzMeier merged commit 611ab57 into master Feb 24, 2018
@LorenzMeier LorenzMeier deleted the pr-aero-battery-initialization-hotfix branch February 24, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery Estimation Initialization on some Platforms like Intel Aero Fails
7 participants