Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport backup register #8953

Merged
merged 3 commits into from
Mar 19, 2018
Merged

Backport backup register #8953

merged 3 commits into from
Mar 19, 2018

Conversation

simonegu
Copy link
Contributor

@simonegu simonegu commented Feb 23, 2018

Change to be coherent with the change on NuttX upstream, in the future
STM32_BKP_BASE will be removed. This is using the definition over stm32_rtc.h interface.
In addition, the definition of STM32_BKP_BASE is not correct for stm32f7.

This PR also add a missing definition for stm32f7 boards for up_systemreset() which was usually included in stm32.h which is not defined for stm32f7 boards.

Simone Guscetti added 2 commits February 23, 2018 21:50
Change to be coherent with the change on NuttX upstream, in the future
STM32_BKP_BASE will be removed. This is using the definition over stm32_rtc.h interface.
This is included in other stm32 architectures in the stm32.h file.
LorenzMeier
LorenzMeier previously approved these changes Feb 23, 2018
@LorenzMeier
Copy link
Member

Thanks!

@simonegu simonegu changed the title Backport backup register [WIP] Backport backup register Feb 23, 2018
@LorenzMeier
Copy link
Member

Is this still WIP?

@simonegu
Copy link
Contributor Author

@LorenzMeier the only issue is the compilation error on px4cannode which I did not have the time to look in detail.

@simonegu
Copy link
Contributor Author

Update: Old chip such as the one used for px4cannode does not have the newest definition. I inserted an ifndef in case the new interface is not defined and it will use the legacy one.

@simonegu simonegu changed the title [WIP] Backport backup register Backport backup register Mar 16, 2018
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simonegu. I tested that reboot -b works now on fmu-v5.

@bkueng bkueng merged commit 20905ce into master Mar 19, 2018
@bkueng bkueng deleted the pr_v5_back_port_bkp_register branch March 19, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants