Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete VT_FW_PITCH_TRIM parameter #9014

Merged
merged 1 commit into from
Mar 7, 2018
Merged

delete VT_FW_PITCH_TRIM parameter #9014

merged 1 commit into from
Mar 7, 2018

Conversation

dagar
Copy link
Member

@dagar dagar commented Mar 5, 2018

We don't need this in addition to regular TRIM.

@dagar dagar requested a review from RomanBapst March 5, 2018 05:31
@dagar dagar added the Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! label Mar 5, 2018
@dagar dagar requested a review from bresch March 5, 2018 06:41
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that useful for tailsitter (and tiltrotors with tilting wings) since the trim is not the same during hover and FW flight?

@dagar
Copy link
Member Author

dagar commented Mar 5, 2018

It's only being added to the actuator_control coming from the FW controller. In master - https:/PX4/Firmware/blob/master/src/modules/vtol_att_control/tailsitter.cpp#L403-L404

bresch
bresch previously approved these changes Mar 5, 2018
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, not useful.

Copy link
Contributor

@RomanBapst RomanBapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure if the problem in the past was that we did not have the trim implemented for aux.
At the moment I don't see a reason for it to exist.

@dagar dagar merged commit 2ce8b6a into master Mar 7, 2018
@dagar dagar deleted the pr-vtol_fw_pitch_trim branch March 7, 2018 14:09
@jux2
Copy link

jux2 commented Mar 20, 2018

I've been using this parameter for a tiltwing that hovers at different angle to forward flight (like @bresch said). What's alternative to set FW pitch angle different to MC? Cheers

@dagar
Copy link
Member Author

dagar commented Mar 20, 2018

@jux2 if you're talking about the FW frame vs MC (not specifically the actuator trim) then take a look at the fixedwing pitch setpoint offset (FW_PSP_OFF).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants