Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc.sensors : fix startup for lidars on Pixhawk boards #9058

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

mhkabir
Copy link
Member

@mhkabir mhkabir commented Mar 11, 2018

The check was not changed back to PX4FMU_V2 after we merged V3 and V2 configs.

This is a hotfix till we actually properly structure this whole sensors startup mess. This current way does not scale well as we add new boards and/or drivers.

@mhkabir mhkabir requested a review from dagar March 11, 2018 21:39
@dagar
Copy link
Member

dagar commented Mar 11, 2018

Add the full range?

@mhkabir
Copy link
Member Author

mhkabir commented Mar 11, 2018

@dagar Added v4PRO. Others don't seem to expose Serial4 and/or have no documentation about UART to port mappings.

@Antiheavy
Copy link
Contributor

I'm not sure this is related to your PR, but we've been struggling to get a TFmini up and running on UART8 on a FMUv4 board. We are using ttys6 (is this serial 4?), aka hardware UART8 going to PE0 and PE1 on the stm32.
We sometimes get it to respond to a single "tfmini test" command in console, but it sends unreasonable results and then will not respond on a second "tfmini test" command.
image
Any thoughts? Is this unrelated?

@mhkabir
Copy link
Member Author

mhkabir commented Mar 12, 2018

I believed that you're using the port meant for FrSky telemetry. I'm not fully sure, but I believe that it has some additional hardware on the port specifically needed for the FrSky telemetry. This is probably the reason for the failures.

@mhkabir
Copy link
Member Author

mhkabir commented Mar 12, 2018

@Antiheavy yep. Just checked. It has an inverter on it.

@Antiheavy
Copy link
Contributor

@mhkabir thanks for checking that, however, the FMUv4 hardware we are using is slightly different than Pixracer. On our board this port does not have the inverter on it; it has the Rx/Tx traces from the STM32 PE0 and PE1 pins running straight out to a connector. Is there anything in the firmware that prevents us from using this port for a TFmini (or generically for anything else)?

@mhkabir
Copy link
Member Author

mhkabir commented Mar 12, 2018

Hmm alright. I think you should be fine in that case, from a software perspective. I don't have any better insights at this point without actually debugging on the hardware.

@Antiheavy
Copy link
Contributor

@mhkabir okay thanks for checking.

@mhkabir
Copy link
Member Author

mhkabir commented Mar 15, 2018

@dagar Good to merge?

@dagar
Copy link
Member

dagar commented Mar 15, 2018

I thought there would be more, but let's go with this for now.

@dagar dagar merged commit 7776789 into master Mar 15, 2018
@dagar dagar deleted the pr-lidar-boot branch March 15, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants