mc_att_control: refactor: switch to matrix library #9161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaEtUgR
force-pushed
the
pr-attitude-control-to-matrix-lib
branch
from
fc7befc
to
1e95841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @dagar, @RomanBapst and @bkueng I'm completely switching to the matrix library for the multicopter attitude controller. That was anyways the plan and is a further step to get rid of duplicate matrix functionality implementation in
mathlib. I concentrated on not refactoring other things to minimize risk for now. I still have some further simplifications in mind.The complete matlib is still in the include chain because of the rotation implementation
#include <conversion/rotation.h>but the controller does not depend on this path of the include chain.This pr is based on #9113 to avoid conflicts.