RTPS test branch #9224
Merged
RTPS test branch #9224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to merge or delete. |
TSC21
reviewed
Apr 2, 2018
| @@ -670,6 +670,10 @@ then | |||
| then | |||
| mavlink start -d ${MAVLINK_COMPANION_DEVICE} -b 115200 -m minimal -r 1000 | |||
| fi | |||
| if param compare SYS_COMPANION 6460800 | |||
There was a problem hiding this comment.
Any reason to establish the RTPS client to half the baud rate of the ESP8266?
There was a problem hiding this comment.
I was following another example at the time using this baudrate. Feel free to change it to a more appropriate default, or add a range of desired rates.
There was a problem hiding this comment.
I see. @avinash-palleti do you see any problem on keeping the baudrate at the max possible?
|
This is safe to merge. SYS_COMPANION options can be expanded as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old test branch I was going to delete, but looks safe to merge for anyone that might want to play with RTPS.