Fix possibility of deep discharge when battery inserted and USB connected #9278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autopilot system shuts down automatically with a dangerously low battery level if the drone isn't currently flying. This prevents deep discharge when forgetting to turn it off or unplug the battery. This feature currently doesn't work when the board is simultaneously connected via USB. Benchtesting sometimes requires usb connection and connected battery (of course propellers removed for safety) and if you then forget to look at the battery level it goes to deep discharge voltages (happened to me while I was in the last PX4 dev call).
The removed check is according to our understanding not needed (anymore) because the battery level is anyways only updated if there is a connected battery detected. See: https:/PX4/Firmware/blob/master/src/modules/systemlib/battery.cpp#L207
commander: Remove usb_ connected flag on battery warnings
Battery warning gets only fired if a battery is inserted.