Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC: set default MPC_THR_MAX & MPC_MANTHR_MAX to 1 #9359

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Apr 23, 2018

With the updated mixer (#9062) it's safe to set maximum thrust to 1 (in both cases, if MC_AIRMODE is set, or not set).
So I see no reason to limit the maximum thrust.

@MaEtUgR @RomanBapst

With the updated mixer (#9062) it's safe to set maximum thrust to 1 (in
both cases, if MC_AIRMODE is set, or not set).
So I see no reason to limit the maximum thrust.
@RomanBapst RomanBapst merged commit 12e9671 into master Apr 26, 2018
@RomanBapst RomanBapst deleted the default_max_thurst_one branch April 26, 2018 12:37
@hamishwillee
Copy link
Contributor

Just FYI MPC_THR_MAX is only mentioned in the parameter reference - no where else. With this change all guidance on why you would change this is gone. Is there any reason for having it at all - and if so, should we not document that somewhere?

@bkueng
Copy link
Member Author

bkueng commented Apr 27, 2018

A reason to use it is that you can reduce the max thrust if the vehicle is too powerful. Might not be that important to keep it though.

@MaEtUgR
Copy link
Member

MaEtUgR commented May 2, 2018

@bkueng I agree but maybe we should handle this case globally such that you have a unified maximum throttle configuration, that would reduce the possibility of misconfiguration. For example as a result if you set it too low the vehicle would not have enough thrust to take off also in manual modes instead of a risk of suddenly droping in a certain mode.

@hamishwillee
Copy link
Contributor

hamishwillee commented May 3, 2018

@MaEtUgR @bkueng Thanks. I propose we change the comment:

Comment: Limit max allowed thrust

TO

Comment: Limit max allowed thrust (i.e. on overpowered vehicles).

OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants