Q attitude estimator improvements #9361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting ATT_W_MAG to 0
…city not used This reduces attitude drift on vehicles w/o GPS. The default behavior is unchanged, to use it, disable ATT_ACC_COMP.
|
If you're going to be testing attitude_estimator_q could you cherry-pick the pending mathlib matrix changes as well? https:/PX4/Firmware/pull/9181/commits Only this commit is needed: 909845a |
…cm init Quaterion::from_dcm does not set *this, but just returns the resulting Quaterion.
|
Thanks, that's exactly what I was hoping would be checked. |
This was referenced Apr 28, 2018
bkueng
changed the title
|
Test-flown again, this is good to go |
|
@priseborough Could we get equivalent changes into EKF2? |
LorenzMeier
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings 2 changes to the q estimator:
ATT_W_MAGto 0. @nathantsoi this will help with the omnibusf4sd, since it does not have a mag (You will need to enablemodules/attitude_estimator_qandmodules/local_position_estimatorin the cmake config and setSYS_MC_EST_GROUPto 1). We should consider using these params as default on that board.ATT_ACC_COMP.This could use a bit more testing, also on fixed-wing.
Note that this PR does not change the default behavior.
@MaEtUgR @RomanBapst