Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpu9250 allow a 2nd internal spi instance and remove px4fmu-v4 external #9386

Merged
merged 1 commit into from
May 4, 2018

Conversation

dagar
Copy link
Member

@dagar dagar commented Apr 30, 2018

RE: #9372

Adding a fake "external" SPI bus to px4fmu-v4 isn't quite right because the rotations will likely be wrong (depending on the board).

This PR partially reverts #9372 and creates a second optional MPU device for the px4fmu-v4.

Note: this is still horrible, we need to find a better way to split the drivers and board configurations.

@dagar dagar force-pushed the pr-mpu9250_external branch 4 times, most recently from 747b915 to ac20c71 Compare May 1, 2018 00:41
Copy link
Member

@AlexKlimaj AlexKlimaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 483 of "main.cpp" needs a "t".

while ((ch = getopt(argc, argv, "XISstR:")) != EOF) {

@dagar
Copy link
Member Author

dagar commented May 2, 2018

Thanks, updated.

@dagar
Copy link
Member Author

dagar commented May 4, 2018

@AlexKlimaj good to go?

@AlexKlimaj
Copy link
Member

@dagar Yes, we have been flying it without issue. The only weird thing is the mag rotations in the driver that were needed to get it to match the lis3mdl.

@dagar
Copy link
Member Author

dagar commented May 4, 2018

Alright, let's merge this and continue discussing in another issue.

I still don't know how to rectify the mpu9250 mag rotations with the datasheet.

image

image

@dagar dagar merged commit 6b94ef1 into master May 4, 2018
@dagar dagar deleted the pr-mpu9250_external branch May 4, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants