ecl-ekf-tools: fix a bug related to time index calculation #9489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix start and end time indices calculation
dagar
approved these changes
May 19, 2018
|
FYI we're running this script on the SITL mission tests. Output is saved to artifacts. http://ci.px4.io:8080/blue/organizations/jenkins/Firmware/detail/PR-9489/1/artifacts |
|
ok, interesting. While the plots should stay the same the test results in mdat.csv will be quite affected by the fix. |
|
I was planning to eventually have the tests actually validate the contents of mdat.csv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug related to start and end time calculation.
the start and end index calculations are currently incorrect:
late_start_index,early_end_index, and theinnov_indices