Pr snapdragon follow up #9503
Merged
Pr snapdragon follow up #9503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks good. I don't have an answer for putchar at the moment. |
Closed
dagar
force-pushed
the
pr-snapdragon_follow_up
branch
from
cfd5ced
to
c248abe
Compare
RomanBapst
commented
May 22, 2018
| @@ -165,7 +165,7 @@ class DfMpu9250Wrapper : public MPU9250 | |||
| math::LowPassFilter2p _gyro_filter_y; | |||
| math::LowPassFilter2p _gyro_filter_z; | |||
|
|
|||
| unsigned _publish_count; | |||
| //unsigned _publish_count; | |||
There was a problem hiding this comment.
Note to myself: Remove this
dagar
force-pushed
the
pr-snapdragon_follow_up
branch
from
c248abe
to
8d625fd
Compare
|
Driverframework was on an invalid commit after the PR was merged. I updated the submodule and squashed into the previous commit. |
Signed-off-by: Roman <[email protected]>
Signed-off-by: Roman <[email protected]>
- just use external mag, if they run together the sensor_mag_0 topic gets corrupted even though they publish on different instances - added sleep at two places, they resolve weird boot problems like params not being read correctly... Signed-off-by: Roman <[email protected]>
RomanBapst
force-pushed
the
pr-snapdragon_follow_up
branch
from
8d625fd
to
d43096a
Compare
RomanBapst
commented
May 23, 2018
|
|
||
| int putchar(int character) | ||
| { | ||
| PX4_ERR("Error: Calling unresolved symbol stub:[%s]", __FUNCTION__); |
There was a problem hiding this comment.
@dagar Is is better if we just print nothing for now? The only thing I worry about is that we forget about this and at some point it bites us.
There was a problem hiding this comment.
Yes I suppose that's a safe alternative.
Signed-off-by: Roman <[email protected]>
|
@RomanBapst things seem to be working and we can come back to it later if we ever develop a better understanding. |
dagar
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #9467
@dagar I cherry-picked the commits from my previous PR which were not addressed by your recent PR's.