ADC support for Omnibus F4 SD #9545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
previously approved these changes
May 28, 2018
bkueng
changed the title
|
I updated the scaling factors according to measured values. |
|
awesome and thank you for doing this! I have not had a chance to test, but
will shortly
…On Thu, May 31, 2018 at 10:13 AM Beat Küng ***@***.***> wrote:
I updated the scaling factors according to measured values.
Merging since it was already approved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9545 (comment)>, or mute
the thread
<https:/notifications/unsubscribe-auth/AAYZmveKOR6dGkKJZUcFgD8oZ7PE0Qylks5t4CSjgaJpZM4UPpE2>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's working already but I still need to set the correct voltage & current scaling factors.
@nathantsoi do you want to cross test on your boards?