Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT v1.4] Fix MAVLink forwarding #22310

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

julianoes
Copy link
Contributor

Backport of #22090.

This adds a reusable class for a simple FIFO ringbuffer.

Signed-off-by: Julian Oes <[email protected]>
This adds a reusable class for a FIFO ringbuffer that accepts variable
length packets. It is using the Ringbuffer class internally.

Signed-off-by: Julian Oes <[email protected]>
This switches from the horribly intertwined ringbuffer implementation to
the new VariableLengthRingbuffer implementation.

By ditching the previous implementation, we fix MAVLink message
forwarding, which didn't work reliably. The reason it didn't work is
that multiple mavlink messages could be added but only one of them was
sent out because the buffer didn't keep track of the messages properly
and only read the first one.

Signed-off-by: Julian Oes <[email protected]>
@julianoes
Copy link
Contributor Author

Going to merge this in, so it can get more testing before being part of a point release.

@julianoes julianoes merged commit e5d92c5 into release/1.14 Nov 9, 2023
5 checks passed
@julianoes julianoes deleted the pr-backport-fix-forwarding branch November 9, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant