Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] CI does not fail even tests fails #5182

Merged
merged 7 commits into from
Jan 8, 2021
Merged

[CI] CI does not fail even tests fails #5182

merged 7 commits into from
Jan 8, 2021

Conversation

hong19860320
Copy link
Collaborator

@hong19860320 hong19860320 commented Jan 7, 2021 •
edited
Loading

  1. 修复CI任务中调用build_android.sh时即使出现编译错误也不会失败的问题，使PR [android] support ndk version upgrade,test=develop #5120 得以逃过CI的检查；
  2. 由于PR [android] support ndk version upgrade,test=develop #5120 在android+clang的情况下使用ndk自带的android.toolchain.cmake，但它存在覆盖CMAKE_FIND_ROOT_PATH的问题，而导致find_path即使指定完整路径也无法找到目标文件，因此，在find_path时使用CMAKE_FIND_ROOT_PATH_BOTH，具体原因请参考NDK cmake toolchain overrides CMAKE_FIND_ROOT_PATH android/ndk#912 https://juejin.cn/post/6847009772344967175

@hong19860320 hong19860320 changed the title [CI] Test ci, don't merge! [CI] CI does not fail even tests fails Jan 7, 2021
DannyIsFunny
DannyIsFunny approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong19860320 hong19860320 merged commit 26c228b into PaddlePaddle:develop Jan 8, 2021
hong19860320 added a commit to hong19860320/Paddle-Lite that referenced this pull request Jan 8, 2021
@hong19860320
[CI] CI does not fail even tests fails (PaddlePaddle#5182)
1b9e727
@hong19860320 hong19860320 mentioned this pull request Jan 8, 2021
Merged
hong19860320 added a commit to hong19860320/Paddle-Lite that referenced this pull request Jan 8, 2021
@hong19860320
[Cherry-pick][CI] CI does not fail even tests fails (PaddlePaddle#5182)
d79c509 
test=develop
hong19860320 added a commit to hong19860320/Paddle-Lite that referenced this pull request Jan 8, 2021
@hong19860320
[Cherry-pick][CI] CI does not fail even tests fails (PaddlePaddle#5182)
2f669c6 
test=develop
hong19860320 added a commit that referenced this pull request Jan 9, 2021
@hong19860320
[Cherry-pick][CI] CI does not fail even tests fails (#5182) (#5192)
82a64f4 
test=develop
hong19860320 added a commit that referenced this pull request Jan 10, 2021
@hong19860320
[Cherry-pick][CI] CI does not fail even tests fails (#5182) (#5194)
bb2a665 
test=develop
xiehanlin pushed a commit to xiehanlin/Paddle-Lite that referenced this pull request Jan 27, 2021
@hong19860320 @xiehanlin
[CI] CI does not fail even tests fails (PaddlePaddle#5182)
bb62b2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyIsFunny DannyIsFunny DannyIsFunny approved these changes

@Leonardo-Ding Leonardo-Ding Awaiting requested review from Leonardo-Ding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hong19860320 @DannyIsFunny