Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 4 No.31】Case7:paddle.distribution.Beta #51847

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

Difers
Copy link
Contributor

@Difers Difers commented Mar 20, 2023

PR types

Bug fixes

PR changes

Others

Describe

#49922 原题目报错其实是broadcast的错误 已在 #49980 中被修复
但在gpu环境中测试会发现依旧错误,经检测是beta中调用stack算子导致的div 0错误
解决方案: 在gpu kernel代码中添加检查,防止div 0, 并在cpu端也加入检查,保持一致 ,并增加相应的单测代码.

相关链接:#51281 (comment)

@Difers Difers changed the title fix beta(true stack) 【PaddlePaddle Hackathon 4 No.31】fix beta Mar 20, 2023
@Difers Difers changed the title 【PaddlePaddle Hackathon 4 No.31】fix beta 【PaddlePaddle Hackathon 4 No.31】Case7:paddle.distribution.Beta Mar 20, 2023
@paddle-bot paddle-bot bot added the contributor External developers label Mar 20, 2023
@Difers Difers changed the title 【PaddlePaddle Hackathon 4 No.31】Case7:paddle.distribution.Beta 【Hackathon 4 No.31】Case7:paddle.distribution.Beta Mar 21, 2023
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 32baca9 into PaddlePaddle:develop Mar 22, 2023
@luotao1 luotao1 mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants