Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.93】增加 linux 下 cpu tensor file_descriptor 传输方案 #53495

Closed
wants to merge 3 commits into from
Closed

【Hackathon No.93】增加 linux 下 cpu tensor file_descriptor 传输方案 #53495

wants to merge 3 commits into from

Conversation

zhangyuqin1998
Copy link
Contributor

PR types

New features

PR changes

APIs

Description

#50663 (comment)

@paddle-bot
Copy link

paddle-bot bot commented May 4, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels May 4, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 4, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@zhangyuqin1998 zhangyuqin1998 changed the title init 【Hackathon No.93】增加 linux 下 cpu tensor file_descriptor 传输方案 May 4, 2023
@zhangyuqin1998 zhangyuqin1998 mentioned this pull request May 4, 2023
Closed
@Ligoml Ligoml mentioned this pull request May 5, 2023
Closed
@ZHUI ZHUI requested a review from DesmonDay May 18, 2023 12:10
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented May 19, 2023

Sorry to inform you that 39926ba's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators May 20, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation May 20, 2023
@ZHUI
Copy link
Collaborator

ZHUI commented May 22, 2023

@zhangyuqin1998 很多CI都挂的，看一下？

ZHUI
ZHUI reviewed May 22, 2023
View reviewed changes
paddle/fluid/pybind/tensor.cc
memory::allocation::MemoryMapAllocation *>(
holder.get());

// 如果这个tensor已经被共享过, 就可以直接返回它的metadata
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要英文注释

ZHUI
ZHUI reviewed May 22, 2023
View reviewed changes
paddle/fluid/pybind/tensor.cc
vectorize(self.dims()), self.lod());
},
R"DOC(
aaa.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc 补充

paddle/fluid/pybind/tensor.cc

return tensor;
},
R"DOC(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc补充

@paddle-bot
Copy link

paddle-bot bot commented May 27, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@zhangyuqin1998 zhangyuqin1998 deleted the tensor_file_descriptor branch November 21, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI left review comments

@DesmonDay DesmonDay Awaiting requested review from DesmonDay

Assignees

@luotao1 luotao1

@ZHUI ZHUI

@Ligoml Ligoml

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangyuqin1998 @ZHUI @luotao1 @Ligoml