Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FastDeploy] support ppdet with fastdeploy on many hardwares #7950

Merged
merged 11 commits into from
Apr 4, 2023

Conversation

DefTruth
Copy link
Contributor

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Mar 15, 2023

Thanks for your contribution!

import ast
parser = argparse.ArgumentParser()
parser.add_argument(
"--model", required=True, help="Path of PaddleSeg model.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 笔误:PaddleSeg->PaddleDetection
  2. 建议改为--model_dir,与套件内其他使用习惯一致

parser.add_argument(
"--model", required=True, help="Path of PaddleSeg model.")
parser.add_argument(
"--image", type=str, required=True, help="Path of test image file.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议改为--image_file或者--image_dir与套件其他地方习惯一致


# settting for runtime
runtime_option = build_option(args)
model = fd.vision.detection.PPYOLOE(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个PPYOLOE不需要根据不同模型来变化吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关于这点,现在是在文档中进行说明。后续将会升级为,根据对arch关键字,直接通过读config文件来判断模型是否被支持,到时应该就只要一个类进行了,类似fastdeploy.vision.detection.PaddleDetectionModel这样子

@DefTruth DefTruth marked this pull request as ready for review March 28, 2023 09:19
@jerrywgz jerrywgz merged commit 3150060 into PaddlePaddle:develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants