Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adam/AdamW] Update adamw.py #9290

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HydrogenSulfate
Copy link

@HydrogenSulfate HydrogenSulfate commented Oct 18, 2024

PR types

Function optimization

PR changes

Others

Description

amsgrad will be supported in PaddlePaddle/Paddle#68079 and added into parameter list of those two optimizers, therefore number of return value of _C_ops.XX will be incresed by 1. So _ need to be replaced with *_ for compatibility.

Copy link

paddle-bot bot commented Oct 18, 2024

Thanks for your contribution!

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.77%. Comparing base (1770b51) to head (9e0bc11).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9290      +/-   ##
===========================================
+ Coverage    52.62%   52.77%   +0.14%     
===========================================
  Files          661      661              
  Lines       107344   107344              
===========================================
+ Hits         56494    56650     +156     
+ Misses       50850    50694     -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant