Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unittest for equation/pde/base.py #397

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

jiamingkong
Copy link
Contributor

@jiamingkong jiamingkong commented Jun 19, 2023

PR types

Others

PR changes

Others

Describe

Adding unittest for equation/pde/base.py

---------- coverage: platform win32, python 3.9.13-final-0 -----------
Name                                                                                          Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------------
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\__init__.py             8      0   100%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\base.py                26      0   100%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\biharmonic.py          17     13    24%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\laplace.py             15     11    27%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\navier_stokes.py       58     53     9%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\normal_dot_vec.py      13      9    31%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\poisson.py             13      9    31%
C:\Users\kinet\anaconda3\envs\paddle\Lib\site-packages\ppsci\equation\pde\viv.py                 20     13    35%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                           170    108    36%

============================================================================================================================ 8 passed, 3 warnings in 6.20s

@paddle-bot
Copy link

paddle-bot bot commented Jun 19, 2023

Thanks for your contribution!

@HydrogenSulfate
Copy link
Collaborator

HydrogenSulfate commented Jun 19, 2023

code-style-check CI 挂了,提交之前请安装 pre-commit

pip install pre-commit
pre-commit install

@jiamingkong
Copy link
Contributor Author

code-style-check CI 挂了,提交之前请安装 pre-commit

pip install pre-commit
pre-commit install

Hi,感谢提醒,我已经修复了这个问题

@HydrogenSulfate
Copy link
Collaborator

覆盖率只有92%?

@HydrogenSulfate
Copy link
Collaborator

可以在PR里贴上pytest 的运行结果

@jiamingkong
Copy link
Contributor Author

可以在PR里贴上pytest 的运行结果

您好,应该是漏了str方法,缺了几行。现在已经修正。执行结果在该PR最早的消息上已经更新

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 063788f into PaddlePaddle:develop Jun 20, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 20, 2023
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
* Adding unittest for equation/pde/base.py

* Black code

* Changed the last unit test case

* pre-commit

* Adding more test for 100% coverage

* Black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants