Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard cross-fetch by platform #246

Open
joshmsamuels opened this issue Oct 3, 2021 · 1 comment
Open

guard cross-fetch by platform #246

joshmsamuels opened this issue Oct 3, 2021 · 1 comment

Comments

@joshmsamuels
Copy link

This SDK uses browser-or-node to set the user-agent based on the javascript environment being run, however the same logic is not applied to cross-fetch. From my understanding that is because cross-fetch should be platform agnostic.

It looks like cross-fetch tries using XmlHttpRequest to make API calls when the environment is set to web worker

@bzmw
Copy link
Contributor

bzmw commented Nov 16, 2021

Heyo,
Thanks for raising this. We are waiting on lquixada/cross-fetch#78 to be completed before we can close this out. Looks like the open source cogs are turning to get us there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants