Profiler results are now sent to Redis #17459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AffectedArc07
commented
Feb 27, 2022
| ffi_data["round_id"] = GLOB.round_id | ||
| // We dont have to JSON decode here. The other end can worry about a 2-layer decode. | ||
| // Performance matters on this end. It doesnt on the other end | ||
| ffi_data["profile_data"] = current_profile_data |
There was a problem hiding this comment.
Going to see how expensive encode/decode is here, as it may decrease send time due to the send size being much smaller from not having tons of extra escapes in
There was a problem hiding this comment.
Update:
lol no
Yes the send cost is lower, but the encode cost halted DD for 4 whole seconds. We're not doing that.
|
Ran on prod, seems fine |
dearmochi
approved these changes
Mar 8, 2022
Test Merge Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds functionality for throwing profiler data at Redis every time SSprofiler fires
Why It's Good For The Game
By sending the profiler data to something that isn't byond, we can do more things with it, such as track time changes between procs, measure specific procs over time with profiler snapshots, and more.
I plan to have this data received by a Java application encompassing a frontend, redis backend for this, database management and more, but that is still WIP.
As for the performance impact of this, it results at taking this much time to encode and send.
I know this may seem higher than good (especially since FFI blocks), but you have to remember that this SS fires every 5 minutes, which is a pretty long delay. On top of that, I noticed no delay while walking around the station and having this fire every 5 seconds, and thats with 0 latency. Most of the delay is on encoding, which is non-tick-blocking [FFI calls halt the entire tick]. My Redis server is also not on the same machine and is 2 switch hops away, whereas on prod it is simulated inside the same RAM as the game server since its all virtualised, not to mention prod having a much beefier CPU.
Changelog
🆑 AffectedArc07
add: Added support for sending profiler metrics out of the game for finer profiler detail
wip: Frontend coming soon
/:cl: