This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PIE-1859] Extracted Metrics interfaces to plugins-api. #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Sep 3, 2019
metrics/core/src/main/java/tech/pegasys/pantheon/metrics/PantheonMetricsSystem.java
Outdated
Show resolved
Hide resolved
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The Metrics interfaces have been extracted to the plugin-api.
Most of the changes are updates to import locations.
The more noteworthy code changes are:
PantheonMetricsSystemthat extendsMetricsSystemhas been added to include the streamObservations methods.plugin-apihas been added as a module dependency in a few locationsUnsupportedOperationExceptions have been added inPantheonEventsImplwhere new interface methods had not yet been implemented.Fixed Issue(s)
Addresses PIE-1859