Upgrade to Polkadot v1.0.0 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasl
force-pushed
the
polkadot-v1.0.0
branch
2 times, most recently
from
3756413
to
a8a4cee
Compare
HashWarlock
reviewed
Sep 20, 2023
| )?; | ||
|
|
||
| Self::deposit_event(Event::OriginOfShellMinted { | ||
| rarity_type, | ||
| collection_id: origin_of_shell_collection_id, | ||
| collection_id: origin_of_shell_collection_id.into(), | ||
| nft_id, |
There was a problem hiding this comment.
I see most have nft_id.into() but others do not. Do they all need to have .into()?
There was a problem hiding this comment.
Basically PW pallet use CollectionId and NftId from rmrk-primitives, which are not associate type CollectionId and ItemId, so it has to convert.
I do not change PW codes too much, only add into() when the compiler says error.
There was a problem hiding this comment.
The error looks like this
error[E0308]: mismatched types
--> pallets/phala-world/src/nft_sale.rs:1581:19
|
1581 | collection_id: origin_of_shell_collection_id,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected associated type, found `u32`
|
= note: expected associated type `<T as pallet_rmrk_core::Config>::CollectionId`
found type `u32`
= help: consider constraining the associated type `<T as pallet_rmrk_core::Config>::CollectionId` to `u32` or calling a method that returns `<T as pallet_rmrk_core::Config>::CollectionId`
= note: for more information, visit https://doc.rust-lang.org/book/ch19-03-advanced-traits.html
help: call `Into::into` on this expression to convert `u32` into `<T as pallet_rmrk_core::Config>::CollectionId`
|
1581 | collection_id: origin_of_shell_collection_id.into(),
| +++++++
For more information about this error, try `rustc --explain E0308`.
jasl
force-pushed
the
polkadot-v1.0.0
branch
from
a8a4cee
to
cd8bc46
Compare
|
@h4x3rotab I'm merging this now, feel free to review later |
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate@polkadot-v0.9.43...polkadot-v1.0.0
paritytech/cumulus@polkadot-v0.9.43...polkadot-v1.0.0
https:/paritytech/polkadot/releases/tag/v1.0.0
Phala-Network/phala-blockchain#1363
This is a giant PR
Phala-Network/phala-blockchain#1391 requires migration
No upstream migration is needed