Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle syntax errors in ini comments #243

Open
g105b opened this issue Aug 31, 2021 · 0 comments
Open

Handle syntax errors in ini comments #243

g105b opened this issue Aug 31, 2021 · 0 comments
Milestone

Comments

@g105b
Copy link
Member

g105b commented Aug 31, 2021

I just spent the best part of 30 minutes debugging why my partial wasn't expanding, and it turns out it was because I was using extend: partialName rather than extend=partialName.

Because I wasn't using ini syntax, nothing was being extended... this seems like something easy to detect and alert the developer of.

HOWEVER there is an actual bug here, as if the comment doesn't parse as an ini (for example, the following string:)

<!--
THIS IS A COMMENT!
-->

an exception is thrown as the ini parser fails. This feature has regressed functionality by killing HTML comments!

@g105b g105b added this to the v4 milestone Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant