Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback/ Observations on wiki Home page #413

Open
j4m3s opened this issue Feb 25, 2023 · 0 comments
Open

Feedback/ Observations on wiki Home page #413

j4m3s opened this issue Feb 25, 2023 · 0 comments

Comments

@j4m3s
Copy link

j4m3s commented Feb 25, 2023

  • Make "separation of concerns" a link to an external page, as you have done for MVC.
  • I wouldn't necessarily agree with "Having a strong separation of concerns means the HTML view can be completely changed without having to change the PHP controller, and vice versa." I would agree that strong separation of concerns allows the view or model to be changed without needing to change the other. The controller must know about changes to the view. DomTemplate is part of the controller.
  • "meaning that a slight change to the HTML source will potentially break existing PHP code, and require updating the PHP every time the page is edited" - the same would apply to DomTemplate if you changed one of the html attributes it's sensitive to.

I think you're trying to convey that low coupling between the tiers of the architecture reduces the fragility of each tier, makes maintenance easier - even to the point of allowing a web designer to focus on the HTML, a php dev to focus on the code and the output from both to meet neatly in the middle to produce a working application thanks to a few shared principles to let DomTemplate do its work.

  • In the comment block in the code example explaining what's going on you should say what the vars section and title var actually do. Telling us about the extends bit is great - but leaves me wondering about the rest.
  • Change "The entire HTML structure can change, without having to communicate this to PHP" to "The entire HTML structure can change without needing any changes to your PHP code"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant